Skip to content

Fix .env exclude/include fields #30

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 20, 2025

Conversation

sargunv
Copy link
Contributor

@sargunv sargunv commented Mar 20, 2025

Description

os.getenv returns string | None, so this code was previously just creating a set of every character in the value. For example:

EXCLUDE_PLATFORMS=psp

would create a set of {'p', 's'}, which doesn't work when later doing the slug in check.

This PR updates the handling of this config to split by commas, so the user can pass:

EXCLUDE_PLATFORMS="dc,n64,nds,psp,ps,saturn"

and have it work.

Checklist

  • I've tested the changes locally
  • I've updated relevant comments
  • I've assigned reviewers for this PR

Screenshots

@sargunv sargunv force-pushed the fix-exclude-platforms branch from 4cb1c67 to c90419a Compare March 20, 2025 00:32
@gantoine gantoine merged commit 9ee9d3d into rommapp:main Mar 20, 2025
1 check passed
@sargunv sargunv deleted the fix-exclude-platforms branch March 20, 2025 02:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants