Romm App Image Fix / Justfile cross platform dev compatability #26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upgrade - Trunk
Run - trunk fmt
gantoine
approved these changes
Mar 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Converted romm.png in muos-app/RomM/resources/ to RGBA
Previous Image was LA (Grayscale) which was not working before.
Image Analysis Results:
File: romm.png
Mode: LA
Format: PNG
Size: (22, 22)
Has Transparency: True
Number of Channels: 2
Bands: ('L', 'A')
Trunk is causing the issues. Since optimizing the image is what converts it to LA mode which is not compatible with the ui in muos
Its most definitely going to fail the trunk check
Changes to justfile were done to make it buildable on macos or linux since before it was just usable on macos.
Related Issues
None
Checklist
Please check all that apply.
Screenshots