Skip to content

Conversation

Dark98
Copy link
Contributor

@Dark98 Dark98 commented May 28, 2025

Description
For People With Large Rom Collections, Like Me xD

Checklist
Please check all that apply.

  • I've tested the changes locally
  • I've updated relevant comments
  • I've assigned reviewers for this PR

Screenshots

For People With Large Rom Collections
@zurdi15
Copy link
Member

zurdi15 commented May 28, 2025

Thank you for the PR, but this is going to break the app. You need to use the limit+offset, otherwise the app won't handle the request properly for large collections. You can check the API docs for more details

@Dark98
Copy link
Contributor Author

Dark98 commented May 29, 2025

Thank you for the PR, but this is going to break the app. You need to use the limit+offset, otherwise the app won't handle the request properly for large collections. You can check the API docs for more details

I've been using this change for a while & some of my systems have 1.5k+ (highest being 3.7k, nds😅) & haven't encountered any problems? Could you elaborate how it would break it?

@zurdi15
Copy link
Member

zurdi15 commented May 29, 2025

Oh I mean, maybe not breaking maybe but so laggy or something like that (let's say with a collection of 10k games). If you tested with an almost 4k collection games without any issue, then maybe I am understimating the app. We can merge and check if any of those users with extremelly large collections have any issue

@zurdi15 zurdi15 merged commit 1ae5131 into rommapp:main May 29, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants