Add Nintendo/Xbox button layout option #42
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR adds support for Nintendo and Xbox button layout options by introducing a new config file and modifying UI/input handling to toggle between the layouts and persist the selection in the .env file.
- Introduces config.py to centralize button colors and layout definitions.
- Updates UI rendering and input processing in RomM/ui.py and RomM/romm.py to use get_controller_layout().
- Adjusts main.py to initialize controller layout settings and logging paths.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| RomM/ui.py | Removed hard-coded color definitions in favor of config-based layout retrieval. |
| RomM/romm.py | Updated button configuration and input key checking to support layout toggling. |
| RomM/main.py | Loads and sets the controller layout from the environment before starting the app. |
| RomM/config.py | New file defining button layout configurations and helper functions. |
Comments suppressed due to low confidence (1)
RomM/romm.py:738
- Consider adding automated tests to cover the new toggle layout functionality to ensure proper behavior when switching between Nintendo and Xbox layouts.
elif selected_pos == self.start_menu_options[2][1]:
gantoine
approved these changes
Apr 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
config.py.envon toggle