feat: support function for assetFilenames #3397
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Benchmarks Rust |
hyf0
approved these changes
Jan 23, 2025
lansi951
reviewed
Jan 24, 2025
| pub fn value(&self, fn_asset_filename: Option<String>) -> String { | ||
| match self { | ||
| Self::String(value) => value.clone(), | ||
| Self::Fn(_) => fn_asset_filename.expect("AssetFilenamesOutputOption Fn should has value"), |
There was a problem hiding this comment.
assetFileNames should allow value.
Test code:
assetFileNames: (asset) => {
if (
typeof asset.source === 'string' &&
asset.source === 'emitted.txt'
asset.source === 'emitted' &&
asset.type === 'asset'
) {
return '1-[name].[ext]'
}
return '[name].[ext]'
}
Nuxt code:
(chunk) => withoutLeadingSlash(join(nuxt.options.app.buildAssetsDir, `${sanitizeFilePath(filename$1(chunk.name))}.[hash].[ext]`))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The
assetFilenamesis used at ecosystem-ci fornuxt, the pr is intended to support it, relate to nuxt/nuxt#30654.The
emitFileis sync method, but callassetFilenamesfunction is async, if usingblock_onforasync emitFilealways hang at callassetFilenamesfunction, because the js sideemitFileis not finished. So here calculate theassetFilenamesat js side to avoid the issue.close #3253.