Skip to content

feat: generate source maps for css files #3285

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Mar 5, 2025
Merged

feat: generate source maps for css files #3285

merged 6 commits into from
Mar 5, 2025

Conversation

nilptr
Copy link
Contributor

@nilptr nilptr commented Jan 2, 2025

Description

closes #3242

generate source maps for css files when sourcemap option is enabled.

nilptr
nilptr commented Jan 2, 2025
View reviewed changes
nilptr
nilptr commented Jan 2, 2025
View reviewed changes
@nilptr nilptr mentioned this pull request Jan 2, 2025
Closed
@nilptr nilptr changed the title Draft: feat: generate source maps for css files feat: generate source maps for css files Jan 2, 2025
@hyf0 hyf0 self-assigned this Jan 3, 2025
@nilptr nilptr force-pushed the nilptr/feat/css-sourcemap branch 2 times, most recently from 30aaf19 to d19d68d Compare January 19, 2025 15:51
@nilptr
Copy link
Contributor Author

nilptr commented Jan 22, 2025

hi @hyf0 any comment? I can make changes if needed. 👀

@github-actions GitHub Actions
Copy link
Contributor

This PR is considered stale and will be convert to draft soon. Please undraft it if you think it's ready to be reviewed.

@github-actions github-actions bot added the stale label Feb 22, 2025
@hyf0
Copy link
Member

hyf0 commented Feb 22, 2025

hi @hyf0 any comment? I can make changes if needed. 👀

Just solve the conflict. If the CI passed, I'll merge it this week.

@github-actions github-actions bot removed the stale label Feb 24, 2025
@nilptr nilptr force-pushed the nilptr/feat/css-sourcemap branch from d19d68d to 498d680 Compare March 1, 2025 14:17
@nilptr
Copy link
Contributor Author

nilptr commented Mar 3, 2025

hi @hyf0 I have rebased master. I have run just test and it passed all tests. image
Sorry for late reply. I didn't check github last week.

@IWANABETHATGUY IWANABETHATGUY requested a review from hyf0 March 3, 2025 02:51
@hyf0
Copy link
Member

hyf0 commented Mar 3, 2025

@nilptr Please run just roll locally and fix all the problems.

@nilptr
Copy link
Contributor Author

nilptr commented Mar 3, 2025

ok let me fix tonight

@nilptr
Copy link
Contributor Author

nilptr commented Mar 4, 2025 •
edited
Loading

fixed

@nilptr
Copy link
Contributor Author

nilptr commented Mar 4, 2025

ooops, sorry, got more lint errors after cargo fmt. let me fix tonight.

btw, I cannot reproduce this error in "Node Test For Node18" with Node18 locally. do you have any idea?

@hyf0
Copy link
Member

hyf0 commented Mar 4, 2025

ooops, sorry, got more lint errors after cargo fmt. let me fix tonight.

btw, I cannot reproduce this error in "Node Test For Node18" with Node18 locally. do you have any idea?

It's not related to this PR and you can ignore it.

hyf0
hyf0 approved these changes Mar 5, 2025
View reviewed changes
Copy link
Member

@hyf0 hyf0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@hyf0 hyf0 enabled auto-merge March 5, 2025 06:36
@hyf0 hyf0 added this pull request to the merge queue Mar 5, 2025
Merged via the queue into rolldown:main with commit eb0a132 Mar 5, 2025
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hyf0 hyf0 hyf0 approved these changes

Assignees

@hyf0 hyf0

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature Request]: Generate source maps for CSS files
2 participants
@nilptr @hyf0