Skip to content

disables optimization for external namespace when using the in operator #6036

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 28, 2025
Merged

disables optimization for external namespace when using the in operator #6036

merged 1 commit into from
Jul 28, 2025

Conversation

TrickyPi
Copy link
Member

@TrickyPi TrickyPi commented Jul 28, 2025 •
edited
Loading

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

resolves #6035
related PR #6029

Description

We overlooked that externalVariable.isNameSpace could also be true.

@vercel Vercel
Copy link

vercel bot commented Jul 28, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 28, 2025 2:31am

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 28, 2025 •
edited
Loading

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#fix/6035

Notice: Ensure you have installed the latest nightly Rust toolchain. If you haven't installed it yet, please see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust.

or load it into the REPL:
https://rollup-i4w4i2c5s-rollup-js.vercel.app/repl/?pr=6036

@github-actions GitHub Actions
Copy link

Performance report

  • BUILD: 6883ms, 821 MB
    • initialize: 0ms, 24.7 MB
    • generate module graph: 2574ms, 631 MB
      • generate ast: 1347ms, 620 MB
    • sort and bind modules: 394ms, 690 MB
    • mark included statements: 3920ms, 821 MB
      • treeshaking pass 1: 2285ms, 818 MB
      • treeshaking pass 2: 463ms, 843 MB (+3%)
      • treeshaking pass 3: 399ms, 822 MB
      • treeshaking pass 4: 383ms, 822 MB
      • treeshaking pass 5: 380ms, 821 MB
  • GENERATE: 941ms (+67ms, +7.7%), 974 MB (+5%)
    • initialize render: 0ms, 938 MB
    • generate chunks: 66ms, 970 MB (+5%)
      • optimize chunks: 0ms, 957 MB
    • render chunks: 809ms (+170ms, +26.6%), 926 MB (+2%)
    • transform chunks: 19ms, 974 MB (+5%)
    • generate bundle: 0ms, 974 MB (+5%)

@codecov Codecov
Copy link

codecov bot commented Jul 28, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.77%. Comparing base (09794f1) to head (821c209).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #6036      +/-   ##
==========================================
+ Coverage   98.75%   98.77%   +0.01%     
==========================================
  Files         271      271              
  Lines       10597    10597              
  Branches     2828     2828              
==========================================
+ Hits        10465    10467       +2     
+ Misses         91       89       -2     
  Partials       41       41

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@lukastaegert lukastaegert added this pull request to the merge queue Jul 28, 2025
Merged via the queue into master with commit 6031a33 Jul 28, 2025
42 checks passed
@lukastaegert lukastaegert deleted the fix/6035 branch July 28, 2025 04:22
@github-actions GitHub Actions
Copy link

This PR has been released as part of rollup@4.46.1. You can test it via npm install rollup.

@github-actions github-actions bot mentioned this pull request Jul 28, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukastaegert lukastaegert lukastaegert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

in check is broken in Rollup 4.46.0
2 participants
@TrickyPi @lukastaegert