Skip to content

Throw descriptive error message for used export is not defined #6023

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 26, 2025

Conversation

TrickyPi
Copy link
Member

@TrickyPi TrickyPi commented Jul 19, 2025

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
resolves #6007

Description

Copy link

vercel bot commented Jul 19, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 26, 2025 6:36am

Copy link

github-actions bot commented Jul 19, 2025

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#fix/6007

Notice: Ensure you have installed the latest stable Rust toolchain. If you haven't installed it yet, please see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust.

or load it into the REPL:
https://rollup-c24durc0i-rollup-js.vercel.app/repl/?pr=6023

Copy link

github-actions bot commented Jul 19, 2025

Performance report

  • BUILD: 6857ms, 829 MB
    • initialize: 0ms, 24.6 MB
    • generate module graph: 2560ms, 633 MB
      • generate ast: 1365ms, 621 MB
    • sort and bind modules: 394ms, 693 MB
    • mark included statements: 3905ms, 829 MB
      • treeshaking pass 1: 2285ms, 825 MB
      • treeshaking pass 2: 460ms, 829 MB (-2%)
      • treeshaking pass 3: 393ms, 830 MB
      • treeshaking pass 4: 383ms, 809 MB (-3%)
      • treeshaking pass 5: 381ms, 829 MB
  • GENERATE: 709ms (+27ms, +3.9%), 925 MB
    • initialize render: 0ms, 904 MB (+12%)
    • generate chunks: 87ms (+36ms, +72.5%), 896 MB (+7%)
      • optimize chunks: 0ms, 882 MB (+7%)
    • render chunks: 656ms (+47ms, +7.7%), 899 MB
    • transform chunks: 17ms, 925 MB
    • generate bundle: 0ms, 925 MB

Copy link

codecov bot commented Jul 19, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.79%. Comparing base (bdd21e4) to head (33bd08f).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #6023   +/-   ##
=======================================
  Coverage   98.79%   98.79%           
=======================================
  Files         270      270           
  Lines       10577    10583    +6     
  Branches     2821     2823    +2     
=======================================
+ Hits        10450    10456    +6     
  Misses         87       87           
  Partials       40       40           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks a lot!

@lukastaegert lukastaegert added this pull request to the merge queue Jul 26, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Jul 26, 2025
@lukastaegert lukastaegert enabled auto-merge July 26, 2025 06:08
@lukastaegert lukastaegert added this pull request to the merge queue Jul 26, 2025
Merged via the queue into master with commit 7aad424 Jul 26, 2025
41 checks passed
@lukastaegert lukastaegert deleted the fix/6007 branch July 26, 2025 07:01
Copy link

This PR has been released as part of rollup@4.45.3. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Rollup fails with chained assignments
2 participants