Skip to content

feat: upgrade to NAPI-RS 3 stable #6027

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 26, 2025
Merged

feat: upgrade to NAPI-RS 3 stable #6027

merged 1 commit into from
Jul 26, 2025

Conversation

Brooooooklyn
Copy link
Contributor

@Brooooooklyn Brooooooklyn commented Jul 22, 2025 •
edited
Loading

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:

Description

Upgrade to NAPI-RS 3.0, see https://napi.rs/blog/announce-v3 for more details

@vercel Vercel
Copy link

vercel bot commented Jul 22, 2025 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 26, 2025 7:24am

@codecov Codecov
Copy link

codecov bot commented Jul 22, 2025 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.79%. Comparing base (7aad424) to head (4341c92).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master    #6027   +/-   ##
=======================================
  Coverage   98.79%   98.79%           
=======================================
  Files         270      270           
  Lines       10583    10583           
  Branches     2823     2823           
=======================================
  Hits        10456    10456           
  Misses         87       87           
  Partials       40       40

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

lukastaegert
lukastaegert reviewed Jul 23, 2025
View reviewed changes
Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, and the workflow improvements are really cool. There is just one job that stands out: The riscv64gc-unknown-linux-gnu build now takes over 20 minutes as opposed to less than 3 minutes it took before. Nearly all of this goes apparently to the installation of the additional dependency. If this is really needed, I wonder if we can switch to a pre-built docker image to handle this? Do you have any insights?

@Brooooooklyn
Copy link
Contributor Author

Brooooooklyn commented Jul 23, 2025 •
edited
Loading

@lukastaegert I believe this is just a network flaky with GitHub Actions, it's only take 1m14s to finish the build before I created this pr: https://github.com/Brooooooklyn/rollup/actions/runs/16449479343/job/46490558015

CleanShot 2025-07-23 at 14 13 23@2x

Can you retry the build and let's see if the slow CI issue still occurs?

@Brooooooklyn
Copy link
Contributor Author

The rerun time appears to be reasonable

CleanShot 2025-07-23 at 20 26 28@2x

@lukastaegert lukastaegert added this pull request to the merge queue Jul 26, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Jul 26, 2025
@lukastaegert lukastaegert enabled auto-merge July 26, 2025 05:32
@lukastaegert lukastaegert added this pull request to the merge queue Jul 26, 2025
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Jul 26, 2025
@Brooooooklyn @lukastaegert
feat: upgrade to NAPI-RS 3 stable
4341c92 
# Conflicts:
#	package-lock.json
#	package.json
@lukastaegert lukastaegert enabled auto-merge July 26, 2025 07:23
@lukastaegert lukastaegert added this pull request to the merge queue Jul 26, 2025
Merged via the queue into rollup:master with commit e8532b2 Jul 26, 2025
40 checks passed
@github-actions GitHub Actions
Copy link

This PR has been released as part of rollup@4.45.3. You can test it via npm install rollup.

c9708513-oss
c9708513-oss reviewed Jul 27, 2025
View reviewed changes
Copy link

@c9708513-oss c9708513-oss left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Finish

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lukastaegert lukastaegert lukastaegert approved these changes

+1 more reviewer

@c9708513-oss c9708513-oss c9708513-oss left review comments

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Brooooooklyn @lukastaegert @c9708513-oss