fix: export field order prefer esm #6005
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #6005 +/- ##
=======================================
Coverage 98.79% 98.79%
=======================================
Files 270 270
Lines 10559 10559
Branches 2815 2815
=======================================
Hits 10432 10432
Misses 87 87
Partials 40 40 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
|
This PR has been released as part of rollup@4.45.0. You can test it via |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains:
Are tests included?
I'm not totally clear on how I would approach testing this 😓.
Breaking Changes?
List any relevant issue numbers:
Description
The way the
exportsfield is configured in thepackage.json's cause the commonjs version of the package to always be used in environments that pass in both arequireandimportcondition (most bundled envs).This is because the way export conditions are matched is in the object order it checks each condition to see if it was provided. In this case since
requireis earlier in the list it is always preferred.