-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Remove limit on max parallel file ops #5986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
5f807ea
to
0a296b9
Compare
Thank you for your contribution! ❤️You can try out this pull request locally by installing Rollup via npm install rollup/rollup#gh-5848_remove_file_ops_limit Notice: Ensure you have installed the latest stable Rust toolchain. If you haven't installed it yet, please see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust. or load it into the REPL: |
Performance report
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5986 +/- ##
==========================================
- Coverage 98.78% 98.78% -0.01%
==========================================
Files 270 270
Lines 8735 8734 -1
Branches 1510 1510
==========================================
- Hits 8629 8628 -1
Misses 73 73
Partials 33 33 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
This PR has been released as part of rollup@4.44.0. You can test it via |
Hi @lukastaegert, I’m currently encountering an Here’s an example error log (paths simplified):
I’m still investigating on my side but wanted to share this in case it helps track related issues. Thanks so much for your work on Rollup! 🙏 Package: |
I downgraded Rollup to |
This PR contains:
Are tests included?
Breaking Changes?
List any relevant issue numbers:
load
hook is called concurrently more thanmaxParallelFileOps
in watch mode #5848Description
If we hit this limit for
this.load
calls, it leads to a very unpleasant "hanging" situation for users.