Skip to content

Conversation

TrickyPi
Copy link
Member

This PR contains:

  • bugfix
  • feature
  • refactor
  • documentation
  • other

Are tests included?

  • yes (bugfixes and features will not be merged without tests)
  • no

Breaking Changes?

  • yes (breaking changes will not be merged unless absolutely necessary)
  • no

List any relevant issue numbers:
resolves #5701

Description

Copy link

vercel bot commented Jan 18, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
rollup ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jan 18, 2025 6:06am

Copy link

github-actions bot commented Jan 18, 2025

Thank you for your contribution! ❤️

You can try out this pull request locally by installing Rollup via

npm install rollup/rollup#gh-5701

Notice: Ensure you have installed the latest stable Rust toolchain. If you haven't installed it yet, please see https://www.rust-lang.org/tools/install to learn how to download Rustup and install Rust.

or load it into the REPL:
https://rollup-9feeaazmk-rollup-js.vercel.app/repl/?pr=5806

Copy link

Performance report

  • BUILD: 7570ms, 736 MB
    • initialize: 0ms, 27.3 MB
    • generate module graph: 2807ms, 549 MB
      • generate ast: 1258ms, 543 MB
    • sort and bind modules: 414ms, 595 MB
    • mark included statements: 4336ms, 736 MB
      • treeshaking pass 1: 1397ms, 697 MB
      • treeshaking pass 2: 681ms, 718 MB
      • treeshaking pass 3: 285ms, 723 MB
      • treeshaking pass 4: 267ms, 727 MB
      • treeshaking pass 5: 312ms, 730 MB
      • treeshaking pass 6: 259ms, 731 MB
      • treeshaking pass 7: 240ms, 730 MB
      • treeshaking pass 8: 234ms, 736 MB
      • treeshaking pass 9: 218ms, 730 MB
      • treeshaking pass 10: 219ms, 733 MB
      • treeshaking pass 11: 216ms, 736 MB
  • GENERATE: 744ms, 974 MB
    • initialize render: 0ms, 868 MB
    • generate chunks: 74ms, 880 MB
      • optimize chunks: 0ms, 870 MB
    • render chunks: 653ms, 948 MB
    • transform chunks: 17ms, 974 MB
    • generate bundle: 0ms, 974 MB

Copy link

codecov bot commented Jan 18, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 99.01%. Comparing base (8e814a5) to head (9bdd7a0).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #5806   +/-   ##
=======================================
  Coverage   99.01%   99.01%           
=======================================
  Files         259      260    +1     
  Lines        8117     8118    +1     
  Branches     1370     1370           
=======================================
+ Hits         8037     8038    +1     
  Misses         53       53           
  Partials       27       27           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@lukastaegert lukastaegert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, good catch!

@lukastaegert lukastaegert added this pull request to the merge queue Jan 19, 2025
Merged via the queue into master with commit b9eeec2 Jan 19, 2025
42 checks passed
@lukastaegert lukastaegert deleted the gh-5701 branch January 19, 2025 06:57
Copy link

This PR has been released as part of rollup@4.31.0. You can test it via npm install rollup.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IIFE bundle generation adds an extra 't' character to the function call resulting in a runtime error
2 participants