Skip to content

wp-cli-version-check.yml: Use gh to fetch WP CLI release info #1585

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 10, 2025
Merged

wp-cli-version-check.yml: Use gh to fetch WP CLI release info #1585

merged 1 commit into from
Jul 10, 2025

Conversation

tangrufus
Copy link
Member

@tangrufus tangrufus commented Jul 10, 2025 •
edited
Loading

To prevent updating wp_cli_version to null, e.g: #1583 and #1584

  1. Use gh which exits with non-zero code when encountering errors
  2. Use GH_TOKEN to prevent API calls from hitting rate limits

Root cause for #1583 and #1584 is unknown. I suspect the curl command is being rate limited.

@tangrufus tangrufus requested review from retlehs and swalkinshaw July 10, 2025 11:06
retlehs
retlehs approved these changes Jul 10, 2025
View reviewed changes
Copy link
Member

@retlehs retlehs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great update, confirmed working as expected again

Thank you!

@retlehs retlehs merged commit f848a01 into roots:master Jul 10, 2025
2 checks passed
@tangrufus tangrufus deleted the cli-ver branch July 10, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@retlehs retlehs retlehs approved these changes

@swalkinshaw swalkinshaw Awaiting requested review from swalkinshaw

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tangrufus @retlehs