🩹 Add retry to adding PPA's #1568
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Something that happens fairly frequently for folks is a network failure when Trellis tries to add the PPA for PHP, MariaDB, or Nginx. The failure looks like this:
The provisioning will sometimes continue a bit further before ending in a failure, and you're left with an unusable VM. Almost always, immediately trying to re-provision will work without an issue.
This PR adds 3 retries to any failures when trying to add a PPA.