Mitigate REST API cache poisoning via Method Override #1556
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
retlehs
approved these changes
Jan 23, 2025
tangrufus
approved these changes
Jan 27, 2025
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Assuming a website chooses to cache responses for specific API routes in the WP REST API (like /wp-json/wp/v2/posts). An attacker could use the
X-HTTP-Method-Overrideheader to request an endpoint (i.e. /wp/v2/posts/1) until the cache isSTALEand trigger an update of the cache from the response that served the HEAD request instead of the GET request. The endpoint would then return an empty response body.Normal routes are not affected by this, but since WP allows method overrides against the REST API, this could become an issue for headless WP instances.