Skip to content

Adding server tuning adjustments for PHP FPM #1444

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 17 commits into from
Closed

Adding server tuning adjustments for PHP FPM #1444

wants to merge 17 commits into from

Conversation

paulbrzeski
Copy link
Contributor

Sharing a couple of changes we've made to our Trellis so we can fine tune PHP settings for high traffic websites.

Changes include,

  • PHP-FPM crash prevention and optimisation
  • Small improvements to make things more semantic
  • Various configs to support above

This PR only provides the defaults, you can override these settings like any other using your group_vars configs.

PHP FPM for a server sharing environment with MariaDB.
New variables to add to group_vars/%ENV%/php.yml,

# Allow a max of 100 children, based on 16GB of ram and 164mb per child.
php_fpm_pm_max_children: 100
# Start and go up in small incremenets as we have the CPU to spare.
php_fpm_pm_start_servers: 5
php_fpm_pm_min_spare_servers: 5
php_fpm_pm_max_spare_servers: 35
# Allow lots of requests as we have the resources to spare.
php_fpm_pm_max_requests: 1000

# Emergency restart settings.
# Restart after 60 seconds if 10 PHP instances have not responded for 5 min

# Number of child processes not responding
php_fpm_set_emergency_restart_threshold: true
php_fpm_emergency_restart_threshold: 10

# Length of time children not responding.
php_fpm_set_emergency_restart_interval: true
php_fpm_emergency_restart_interval: 5m

# Time to wait before restarting after interval passes.
php_fpm_set_process_control_timeout: true
php_fpm_process_control_timeout: 60s

More info - https://geekflare.com/php-fpm-optimization/

(previously #1430)

@paulbrzeski paulbrzeski mentioned this pull request Oct 25, 2022
Closed
swalkinshaw
swalkinshaw reviewed Jan 28, 2023
View reviewed changes
Copy link
Member

@swalkinshaw swalkinshaw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Would you be able to rebase this to fix the conflict?

roles/php/templates/php-fpm.conf.j2
@@ -0,0 +1,151 @@
;;;;;;;;;;;;;;;;;;;;;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add ; {{ ansible_managed }} here?

paulbrzeski and others added 17 commits March 3, 2023 13:07
@paulbrzeski
Adding server tuning adjustments for PHP FPM
a68c89b
@craigpearson @paulbrzeski
[Security] Due to the default caching of POST requests personal infor…
ea3f133 
…mation can be leaked (roots#1434)

As per: https://www.rfc-editor.org/rfc/rfc7231#section-4.1
@swalkinshaw @paulbrzeski
Skip cache for OPTIONS requests (roots#1435)
d29e048
@swalkinshaw @paulbrzeski
Support ARM64 arch in Mailhog role (roots#1432)
05e56db 
`geerlingguy.mailhog` doesn't support arm64 (Apple Silicon) because the underlying binaries (`mailhog` and `mhsendmail`) don't have official `arm64` builds.

To support this by default, we need to override the url variables to point to forks that have these builds.

This adds a new "shim loader" `mailhog` role which simply loads the proper vars and then passes them to the included `geerlingguy.mailhog` role.
@renovate @swalkinshaw @paulbrzeski
Configure Renovate (roots#1436)
db6d6c5 
* chore(deps): add renovate.json

* Enable ansible-galaxy in renovate config

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
Co-authored-by: Scott Walkinshaw <scott.walkinshaw@gmail.com>
@swalkinshaw @paulbrzeski
Update renovate managers
c52bc0d
@swalkinshaw @paulbrzeski
Fix renovate config
ff17b03
@swalkinshaw @paulbrzeski
Prevent ansible-core 2.13.6 (roots#1448)
3cf1146 
This version has a regression: ansible/ansible#79291
@swalkinshaw @paulbrzeski
Ensure ubuntu-20.04 is used in GitHub workflows (roots#1454)
9f7e3da 
`ubuntu-latest` recently changed to Ubuntu 22.04
@swalkinshaw @paulbrzeski
Remove ansible-core version constraint (roots#1459)
a0aa3bb 
Bugs/regressions in 2.13.6 have been fixed
@swalkinshaw @paulbrzeski
Set development web_user to ansible_user (roots#1464)
570e14f 
This removes another place where `vagrant` is harcoded while still
ensuring its set to that value according to `dev.yml`'s `remote_user`
setting.
@retlehs @paulbrzeski
📝 Update README
6bd0ab7
@swalkinshaw @paulbrzeski
Update boxes to Ubuntu 22.04 (roots#1461)
2aa16a8
@swalkinshaw @paulbrzeski
Run SSH key generate task for local provision only (roots#1473)
17e60fc
@swalkinshaw @paulbrzeski
Replace MailHog with Mailpit (roots#1474)
fd938b6
@swalkinshaw @paulbrzeski
Fix ansible_user references for local provisioning (roots#1479)
817c3e2 
`ansible_user` can't be assumed to be defined during Ansible local
provisioning (the default mode in Vagrant if Ansible is not installed on
the host machine).
@retlehs @paulbrzeski
📝 Update README
80cfd97
@paulbrzeski paulbrzeski force-pushed the php-tuning-settings branch from da0c2e2 to 80cfd97 Compare March 3, 2023 13:13
@paulbrzeski
Copy link
Contributor Author

This should be good to go now @swalkinshaw

@swalkinshaw swalkinshaw mentioned this pull request Jul 25, 2023
Merged
@swalkinshaw
Copy link
Member

See #1496

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@swalkinshaw swalkinshaw swalkinshaw left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@paulbrzeski @swalkinshaw @craigpearson @retlehs