Skip to content

Fix use of reserved characters in wp-cli.yml #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 29, 2023
Merged

Fix use of reserved characters in wp-cli.yml #398

merged 3 commits into from
Jun 29, 2023

Conversation

kellymears
Copy link
Contributor

I don't think the generated wp-cli.yml is compliant with the yml spec.

The “@” (x40, at) and “`” (x60, grave accent) are reserved for future use.

Reserved indicators can't start a plain scalar.

— yaml spec (1.2.2)

yamllint and vscode's default YAML checks report errors, so I think I might be on to something.

test.yml
  1:1       error    syntax error: found character '@' that cannot start any token (syntax)

@kellymears kellymears mentioned this pull request Jun 28, 2023
Closed
3 tasks
@swalkinshaw
Copy link
Member

alias_test.go needs to be updated but otherwise this looks good 👍

@swalkinshaw swalkinshaw merged commit 278e88b into master Jun 29, 2023
@swalkinshaw swalkinshaw deleted the alias-template-yml branch June 29, 2023 22:13
@chrillep
Copy link

@swalkinshaw when will this be released? 😅

@swalkinshaw
Copy link
Member

@chrillep I'll do one this week (maybe tonight).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kellymears @swalkinshaw @chrillep