Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: roots/trellis-cli
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v1.12.0
Choose a base ref
...
head repository: roots/trellis-cli
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v1.12.1
Choose a head ref
  • 2 commits
  • 5 files changed
  • 1 contributor

Commits on Aug 1, 2024

  1. Refactor Lima config management

    Changes how the CLI generates and manages Lima VM configs to make
    changes like mounted directories be accurately reflected in Lima.
    
    trellis-cli used to generate a config for Lima in
    `.trellis/lima/{name}.yml` which was used for the initial creation of
    the VM. However, even when providing a config to `limactl create`, Lima
    creates a separate config in its managed directory (`$HOME/.lima/{name}/lima.yaml`).
    
    This meant that any subsequent config changes in Trellis might only be
    persisted to the CLI's managed config (in `.trellis`), which would do
    nothing, instead of Lima's config.
    
    For example, if you added a new site to Trellis (or changed the path to
    an existing one), you'd either have to delete the VM entirely and start
    over, or manually make the changes to Lima's config.
    
    This PR removes the old CLI managed config entirely and instead updates
    Lima's config directly (the one in `$HOME/.lima`). This means one less
    file to manage and a single source of truth which will allow proper VM
    udpates.
    
    Now if you change any wordpress sites in development, stopping and
    restarting the VM will apply the new config changes.
    swalkinshaw committed Aug 1, 2024
    Configuration menu
    Copy the full SHA
    bca23c1 View commit details
    Browse the repository at this point in the history

Commits on Aug 3, 2024

  1. Merge pull request #449 from roots/refactor-lima-config-management

    Refactor Lima config management
    swalkinshaw authored Aug 3, 2024
    Configuration menu
    Copy the full SHA
    57a8e99 View commit details
    Browse the repository at this point in the history
Loading