Skip to content

fix(server) fix inject util for zero entry compilers #937

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 6, 2022
Merged

fix(server) fix inject util for zero entry compilers #937

merged 1 commit into from
Jan 6, 2022

Conversation

kellymears
Copy link
Contributor

Type of change

  • PATCH: bugfix

Dependencies added

  • none

Details

Very annoying bug to track down.

  • Fixes an exception thrown when a compiler has no entry assigned to it (totally valid in Webpack 5) and is used in dev mode.
  • Bud wants to inject client scripts on entry but entry doesn't exist.
  • Now, Bud just bails if entry is not an object.

@kellymears kellymears changed the base branch from main to next January 5, 2022 22:57
@kellymears kellymears changed the title Fix server inject fix(server) fix inject util for zero entry compilers Jan 5, 2022
@kellymears kellymears requested review from QWp6t and retlehs January 5, 2022 23:15
@kellymears kellymears modified the milestones: 5.2.0, 5.1.1, 5.1.0 Jan 5, 2022
@kellymears kellymears merged commit cf6b7b1 into next Jan 6, 2022
@kellymears kellymears deleted the fix-server-inject branch January 6, 2022 14:44
@kellymears kellymears mentioned this pull request Jan 17, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@QWp6t QWp6t Awaiting requested review from QWp6t

@retlehs retlehs Awaiting requested review from retlehs

Assignees
No one assigned
Labels
@roots/bud-server
Projects
None yet
Milestone
5.1.0
Development

Successfully merging this pull request may close these issues.
1 participant
@kellymears