fix(purgecss) #905
Merged
fix(purgecss) #905
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kellymears
commented
Jan 1, 2022
| /** | ||
| * Module registration | ||
| * | ||
| * @todo facade bindings to `@roots/bud-extension` |
There was a problem hiding this comment.
The only reason for this register callback is that I need to set/bind the facade for bud.config.js.
this should eventually be moved to @roots/bud-extensions/src/Controller/controller.service.ts
There was a problem hiding this comment.
addressing this in #906. let's get that merged first and then I can remove this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Dependencies added
Details
bud.purgecssfn bindings🥳 this dude has 100% coverage now