-
-
Notifications
You must be signed in to change notification settings - Fork 42
fix(bud-build) directory for emitted assets #900
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tests failing because:
i'm not going to do either of those things. i'm just going to let |
I would like to see #891 merged before doing this. It concerns the API we're using to do this. If there hasn't been any movement/feedback by later today I'm going to go ahead and merge it. |
This is ready. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
dependencies
Pull requests that update a dependency file
@roots/bud
@roots/bud-build
@roots/bud-framework
@roots/sage
test
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ref: #897
Type of change
Dependencies added
Details
First a couple under-the-hood changes:
*.module.css
assets.include
overexclude
for modules.src
. This does not includenode_modules
.node_modules
(font-awesome, etc.) they can set bud to look for modules there with:bud.build.rule.js.setInclude(bud.path('project'))
.js
can be replaced with anybud.build.rule
registered tobud
. by default that includes:js
,css
,image
,font
,json
,yml
,html
,csv
,xml
,toml
. see refactor(@roots/bud-build) build.rules api #891.node_modules
when the majority of users won't be trying to compile things from it directly. Hence, our default. And now, a simpler way to override that default if needed.Output paths
images/
instead ofassets/images
svg/
instead ofassets/
fonts/
instead ofassets/
for @roots/sage:
images/
, instead of the new defaultsvg/