Skip to content

Conversation

kellymears
Copy link
Contributor

@kellymears kellymears commented Nov 27, 2021

where this came up: https://discourse.roots.io/t/bud-and-ecmascript-modules-esm/21743/7

Type of change

  • MINOR: feature

Dependencies added

  • NA

Details

  • adds sync filter: 'build.override' 'config.override' (build namespace is reserved for compiler)
  • modifiesbud.config to pass built config to bud.hook.on('config.override') event.
    • this happens directly before bud.build verifies the configuration (strips undefined and null values)
  • bud.override is just an alias for bud.config.
  • fix: hooks.filter and hooks.promised will now tap the function passed to them if the supplied value is a CallableFunction type

filter example:

bud.hooks.on('config.override', config => ({
  ...config,
  // ...overrides,
})

@github-actions github-actions bot added the test label Nov 29, 2021
@kellymears kellymears requested review from retlehs and QWp6t November 29, 2021 07:23
@kellymears kellymears marked this pull request as ready for review November 29, 2021 07:23
@QWp6t QWp6t changed the title Improve bud.config feat(api-config): uses and improves hooks Nov 29, 2021
@QWp6t QWp6t merged commit 3dacfab into next Nov 29, 2021
@QWp6t QWp6t deleted the improve-override branch November 29, 2021 08:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants