Skip to content

Conversation

rodrigo-brito
Copy link
Owner

@rodrigo-brito rodrigo-brito commented Mar 5, 2023

  • Upgrade go to 1.19
  • Remove calls for external APIs
  • Refactor Series to generic format

@rodrigo-brito rodrigo-brito changed the title Refactor tests and fix decimal precision Refactor tests and remove external API dependency Mar 5, 2023
@rodrigo-brito rodrigo-brito marked this pull request as ready for review March 5, 2023 19:13
@codecov-commenter
Copy link

Codecov Report

Patch coverage: 19.40% and project coverage change: -1.04 ⚠️

Comparison is base (a386008) 48.80% compared to head (292642c) 47.76%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #239      +/-   ##
==========================================
- Coverage   48.80%   47.76%   -1.04%     
==========================================
  Files          19       19              
  Lines        2502     2546      +44     
==========================================
- Hits         1221     1216       -5     
- Misses       1209     1258      +49     
  Partials       72       72              
Impacted Files Coverage Δ
model/model.go 59.59% <0.00%> (-10.65%) ⬇️
exchange/pairs.go 17.85% <15.38%> (-62.15%) ⬇️
plot/chart.go 39.74% <22.22%> (-1.18%) ⬇️
model/series.go 83.33% <62.50%> (-7.58%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@rodrigo-brito rodrigo-brito merged commit 96df103 into main Mar 5, 2023
@rodrigo-brito rodrigo-brito deleted the fix/tests branch March 5, 2023 19:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants