chore(csv): remove unused header #213
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
Codecov ReportBase: 48.80% // Head: 48.80% // No change to project coverage 👍
Additional details and impacted files@@ Coverage Diff @@
## main #213 +/- ##
=======================================
Coverage 48.80% 48.80%
=======================================
Files 19 19
Lines 2502 2502
=======================================
Hits 1221 1221
Misses 1209 1209
Partials 72 72
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
download/download.go
Outdated
| @@ -7,8 +7,8 @@ import ( | |||
| "time" | |||
|
|
|||
| "github.com/rodrigo-brito/ninjabot/service" | |||
|
|
|||
There was a problem hiding this comment.
service is a internal package, can you merge the imports?
|
Gracias Kuaty! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What have you changed and why?
there was a header that was removed from the toSlice() method of the candles and was still being passed as argument, so I removed it.
Related Issues
closes #212
let me know if there's anything else you need me to fix!