Skip to content

Conversation

panapol-p
Copy link
Contributor

What have you changed and why?

add more storage type to support sql (mysql , postgresql , sql server , clickhouse , sqlite)

Related Issues

support more storage type for persist order history #185

@codecov-commenter
Copy link

Codecov Report

Base: 48.52% // Head: 49.07% // Increases project coverage by +0.54% 🎉

Coverage data is based on head (eaec7c8) compared to base (0be7bde).
Patch coverage: 67.42% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #207      +/-   ##
==========================================
+ Coverage   48.52%   49.07%   +0.54%     
==========================================
  Files          17       19       +2     
  Lines        2413     2486      +73     
==========================================
+ Hits         1171     1220      +49     
- Misses       1178     1194      +16     
- Partials       64       72       +8     
Impacted Files Coverage Δ
storage/storage.go 100.00% <ø> (+24.35%) ⬆️
storage/sql.go 67.12% <67.12%> (ø)
storage/local.go 67.79% <67.79%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Copy link
Owner

@rodrigo-brito rodrigo-brito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for the contribution, just a couple of comments.

@panapol-p
Copy link
Contributor Author

Hi, thanks for your previous reviewed, could you please review again.

Copy link
Owner

@rodrigo-brito rodrigo-brito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks great

@rodrigo-brito rodrigo-brito merged commit 9d6ff17 into rodrigo-brito:main Oct 16, 2022
@panapol-p panapol-p deleted the feat/add-sql-storage branch October 16, 2022 15:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants