-
-
Notifications
You must be signed in to change notification settings - Fork 193
feat(storage) : support sql #207
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(storage) : support sql #207
Conversation
Codecov ReportBase: 48.52% // Head: 49.07% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #207 +/- ##
==========================================
+ Coverage 48.52% 49.07% +0.54%
==========================================
Files 17 19 +2
Lines 2413 2486 +73
==========================================
+ Hits 1171 1220 +49
- Misses 1178 1194 +16
- Partials 64 72 +8
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, thanks for the contribution, just a couple of comments.
Hi, thanks for your previous reviewed, could you please review again. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks great
What have you changed and why?
add more storage type to support sql (mysql , postgresql , sql server , clickhouse , sqlite)
Related Issues
support more storage type for persist order history #185