Skip to content

testscript: use unified diff for cmp-style comparisons #131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 1, 2021
Merged

testscript: use unified diff for cmp-style comparisons #131

merged 1 commit into from
Mar 1, 2021

Conversation

myitcv
Copy link
Collaborator

@myitcv myitcv commented Feb 26, 2021

No description provided.

@myitcv myitcv force-pushed the testscript_alternative_diff branch 3 times, most recently from 2a4f6df to 1223ffe Compare February 26, 2021 14:21
@myitcv myitcv mentioned this pull request Feb 26, 2021
Merged
@myitcv myitcv force-pushed the testscript_alternative_diff branch 2 times, most recently from b0bc478 to 147c4e5 Compare March 1, 2021 13:56
mvdan
mvdan approved these changes Mar 1, 2021
View reviewed changes
Copy link
Collaborator

@mvdan mvdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just using unified diffs always SGTM. I can't think of a single time I'd want side-by-side diffs instead. They could always be brought back via a flag, if necessary.

@myitcv myitcv force-pushed the testscript_alternative_diff branch from 147c4e5 to 7ef4de2 Compare March 1, 2021 14:30
@myitcv myitcv force-pushed the testscript_alternative_diff branch from 7ef4de2 to 506c7df Compare March 1, 2021 14:39
@myitcv myitcv merged commit 2630b2f into master Mar 1, 2021
@myitcv myitcv deleted the testscript_alternative_diff branch March 1, 2021 14:49
This was referenced Mar 14, 2021
Closed
Closed
Closed
Closed
Merged
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mvdan mvdan mvdan approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@myitcv @mvdan