Skip to content

cmd/testscript: support -update flag #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 19, 2021
Merged

cmd/testscript: support -update flag #121

merged 1 commit into from
Jan 19, 2021

Conversation

myitcv
Copy link
Collaborator

@myitcv myitcv commented Jan 18, 2021

No description provided.

@myitcv myitcv requested a review from mvdan January 18, 2021 12:47
@myitcv myitcv force-pushed the cmd_testscript_update branch 4 times, most recently from 45ea8d3 to 2e06fa4 Compare January 18, 2021 13:34
rogpeppe
rogpeppe requested changes Jan 18, 2021
View reviewed changes
Copy link
Owner

@rogpeppe rogpeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! AFAICS there are still a couple of issues the need fixing (or at least test cases adding for them if my assessment is flawed)...

@myitcv myitcv force-pushed the cmd_testscript_update branch 2 times, most recently from 4e70325 to 47e2b36 Compare January 18, 2021 14:54
@myitcv
Copy link
Collaborator Author

myitcv commented Jan 18, 2021

Thanks for the review, @rogpeppe. All comments addressed, with one small question by way of reply.

rogpeppe
rogpeppe approved these changes Jan 19, 2021
View reviewed changes
Copy link
Owner

@rogpeppe rogpeppe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with one last thing to do (wouldn't it be nice to have only one copy of the help text?), thanks!

@myitcv
cmd/testscript: support -update flag
4408f18 
This is exactly equivalent to setting testscript.Params.UpdateScripts
@myitcv myitcv force-pushed the cmd_testscript_update branch from 47e2b36 to 4408f18 Compare January 19, 2021 09:06
@myitcv myitcv merged commit 8b0b133 into master Jan 19, 2021
@myitcv myitcv deleted the cmd_testscript_update branch January 19, 2021 09:12
This was referenced Mar 14, 2021
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rogpeppe rogpeppe rogpeppe approved these changes

@mvdan mvdan Awaiting requested review from mvdan

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@myitcv @rogpeppe