Skip to content

Conversation

myitcv
Copy link
Collaborator

@myitcv myitcv commented Jan 18, 2021

Otherwise, in the case a PR is created from a branch that is pushed to
this repo, we create a workflow run for the PR and the branch itself.

Otherwise, in the case a PR is created from a branch that is pushed to
this repo, we create a workflow run for the PR and the branch itself.

Also switch to a fail-fast false strategy (because this is more helpful
when testing multiple Go versions in a matrix)
@myitcv myitcv force-pushed the only_build_master_branch branch from 71ed136 to 61546fa Compare January 18, 2021 06:28
@myitcv myitcv requested a review from mvdan January 18, 2021 06:45
Copy link
Collaborator

@mvdan mvdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personally, I tend to avoid this by just opening PRs from forks :) but this seems like an okay fix too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants