-
Notifications
You must be signed in to change notification settings - Fork 80
Comparing changes
Open a pull request
base repository: rogpeppe/go-internal
base: v1.8.1
head repository: rogpeppe/go-internal
compare: v1.9.0
- 20 commits
- 41 files changed
- 6 contributors
Commits on Jan 12, 2022
-
testscript: print background command output on failure (#148)
When a script has failed, the output of the commands running in the background can be useful to see, so display it then and also in verbose mode.
Configuration menu - View commit details
-
Copy full SHA for dc66b32 - Browse repository at this point
Copy the full SHA dc66b32View commit details -
testscript: support named background commands (#152)
This lets us wait for an individual background command rather than all of them at once.
Configuration menu - View commit details
-
Copy full SHA for f3cb5c2 - Browse repository at this point
Copy the full SHA f3cb5c2View commit details
Commits on Mar 9, 2022
-
testscript: remove errgo dependency (#155)
There's no need to use it and every dependency lost is good.
Configuration menu - View commit details
-
Copy full SHA for b66946f - Browse repository at this point
Copy the full SHA b66946fView commit details
Commits on Mar 12, 2022
-
Configuration menu - View commit details
-
Copy full SHA for f1aca1d - Browse repository at this point
Copy the full SHA f1aca1dView commit details -
Configuration menu - View commit details
-
Copy full SHA for b00b079 - Browse repository at this point
Copy the full SHA b00b079View commit details -
gotooltest: fix Go version regular expression
Trivia: the first defined Go version build constraint is go1.1.
Configuration menu - View commit details
-
Copy full SHA for 635e0f0 - Browse repository at this point
Copy the full SHA 635e0f0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 3461ca1 - Browse repository at this point
Copy the full SHA 3461ca1View commit details
Commits on Apr 22, 2022
-
gotooltest: move default GOPATH out of the main module
Otherwise, commands like `go mod tidy` will try to walk into the default GOPATH directory. At best, that's a waste of resources, since directories like GOMODPATH may contain lots of files. At worst, it results in errors, as directories in GOMODPATH are not valid import paths: --- FAIL: TestScripts/list (0.01s) testscript.go:413: [...] > go mod tidy [stderr] mod/gopath/pkg/mod/fruit.com@v1.1.0/fruit: import path "mod/gopath/pkg/mod/fruit.com@v1.1.0/fruit" should not have @Version We add the test in goproxytest, as goproxytest already uses gotooltest, and we need an external module to reproduce the error.
Configuration menu - View commit details
-
Copy full SHA for 009359f - Browse repository at this point
Copy the full SHA 009359fView commit details
Commits on Jun 20, 2022
-
drop Go 1.16, add Go 1.18 (#158)
While here, bump gotip and the action versions.
Configuration menu - View commit details
-
Copy full SHA for 3b43157 - Browse repository at this point
Copy the full SHA 3b43157View commit details
Commits on Jun 21, 2022
-
testscript: exit 0 in runCoverSubcommand if -help is used
flag.ExitOnError will exit 0 for -h/-help, while the flag.PanicOnError override in runCoverSubcommand was always exiting 2, making the success/failure of running a command with -hhelp depend on whether coverage is active.
Configuration menu - View commit details
-
Copy full SHA for e9142ea - Browse repository at this point
Copy the full SHA e9142eaView commit details
Commits on Jun 24, 2022
-
all: add support for txtar extension and prefer it (#159)
For backwards compatibility, both testscript and goproxytest, which used to glob on `*.txt`, now look for both file extensions. Note that this required a bit of a refactor in testscript, as we cannot use a single glob expression to accomplish this. Code which produces files, such as txtar-addmod, now produces `*.txtar` rather than `*.txt`. Similarly, the public docs now use `*.txtar` too. Note that we leave many txt files in tests untouched; it's unnecessary to change them given the backwards compatibility, and it has zero benefit to the user as they aren't public. Moreover, the diff churn would make this patch harder to review. If a future version of go-internal only supports txtar extensions, then it could replace all of those extensions accordingly. Fixes #126.
Configuration menu - View commit details
-
Copy full SHA for af73bbc - Browse repository at this point
Copy the full SHA af73bbcView commit details
Commits on Jul 6, 2022
-
testscript: add Params.RequireExplicitExec
We also document how top-level commands fed to RunMain work with and without "exec" the same way, and how RequireExplicitExec can drop backwards compatibility for greater consistency. Fixes #163.
Configuration menu - View commit details
-
Copy full SHA for 9d15b66 - Browse repository at this point
Copy the full SHA 9d15b66View commit details
Commits on Jul 28, 2022
-
imports: add 'UnixOS' list of Unix-like systems
From Go 1.19, the build constraint 'unix' proposed in golang/go#20322 is satisfied by any sufficiently Unix-like value of GOOS, as defined by src/go/build/syslist.go. This commit adds a 'UnixOS' list containing the values of GOOS that would satisfy the 'unix' constraint in Go 1.19. Co-authored-by: Paul Jolly <paul@myitcv.io>
Configuration menu - View commit details
-
Copy full SHA for 8da7db8 - Browse repository at this point
Copy the full SHA 8da7db8View commit details -
testscript: add 'unix' condition
From Go 1.19, the build constraint 'unix' proposed in golang/go#20322 is satisfied by any sufficiently Unix-like value of GOOS, as defined by src/go/build/syslist.go. This commit adds a predefined 'unix' condition with the same meaning, available for use in test scripts. The condition is satisfied if the target GOOS is one of the list of Unix-like systems defined in 'imports.UnixOS'. Fixes #166. Co-authored-by: Daniel Martí <mvdan@mvdan.cc>
Configuration menu - View commit details
-
Copy full SHA for 2431384 - Browse repository at this point
Copy the full SHA 2431384View commit details
Commits on Aug 3, 2022
-
testscript: fix RequireExplicitExec error messages
They used args[0], which is the first argument to the command, rather than the command name itself: > gofumpt foo.go FAIL: [...] use 'exec foo.go' rather than 'foo.go' (because RequireExplicitExec is enabled) I believe I introduced this regression when refactoring the pull request due to Roger's review, as I moved the code out of TestMain, where args[0] was still the name of the command to be run. Note that I can't easily add a regression test here, because the testscript command being used in the tests is not a top-level command run as a separate process, so it does not produce stdout nor stderr. The change seems easy enough to review manually, and our tests don't strictly check all error messages anyway. While here, remove the unnecessary use of -verbose.
Configuration menu - View commit details
-
Copy full SHA for bb36173 - Browse repository at this point
Copy the full SHA bb36173View commit details
Commits on Aug 4, 2022
-
testscript: fix RequireExplicitExec error messages
They used args[0], which is the first argument to the command, rather than the command name itself: > gofumpt foo.go FAIL: [...] use 'exec foo.go' rather than 'foo.go' (because RequireExplicitExec is enabled) I believe I introduced this regression when refactoring the pull request due to Roger's review, as I moved the code out of TestMain, where args[0] was still the name of the command to be run. Note that I can't easily add a regression test here, because the testscript command being used in the tests is not a top-level command run as a separate process, so it does not produce stdout nor stderr. The change seems easy enough to review manually, and our tests don't strictly check all error messages anyway. While here, remove the unnecessary use of -verbose.
Configuration menu - View commit details
-
Copy full SHA for 77fe68f - Browse repository at this point
Copy the full SHA 77fe68fView commit details
Commits on Aug 20, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 57a71e0 - Browse repository at this point
Copy the full SHA 57a71e0View commit details
Commits on Aug 22, 2022
-
Configuration menu - View commit details
-
Copy full SHA for 0d96cbe - Browse repository at this point
Copy the full SHA 0d96cbeView commit details -
Configuration menu - View commit details
-
Copy full SHA for c16c0a2 - Browse repository at this point
Copy the full SHA c16c0a2View commit details -
testscript: update docs on set variables
We have been setting `/`, `:`, and `$` for some time, but they weren't documented. Do that. `goversion` doesn't belong here, as it was moved to `gotooltest`. `TMPDIR` was slightly wrong; it has started with a period for some time, to ensure that tools like `go list ./...` don't descend into it.
Configuration menu - View commit details
-
Copy full SHA for 7a6a5f8 - Browse repository at this point
Copy the full SHA 7a6a5f8View commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v1.8.1...v1.9.0