-
Notifications
You must be signed in to change notification settings - Fork 81
Comparing changes
Open a pull request
base repository: rogpeppe/go-internal
base: v1.12.0
head repository: rogpeppe/go-internal
compare: v1.13.1
- 18 commits
- 35 files changed
- 8 contributors
Commits on Feb 16, 2024
-
testscript: fix ptyName() returning /dev/pts/4294967296 on s390x
Use uint32 instead of uint (64-bit in Go on s390x) to store the return value of the TIOCGPTN syscall. This is to avoid the 32-bit value from being stored into a 64-bit buffer and get left-shifted by 32 when dereferencing, turning what should be /dev/pts/1 to /dev/pts/4294967296 on big-endian architectures such as s390x. Special thanks to the explanation and a similar bug fix provided at containerd/console#51
Configuration menu - View commit details
-
Copy full SHA for 8e66eb9 - Browse repository at this point
Copy the full SHA 8e66eb9View commit details
Commits on Mar 8, 2024
-
It's been a while since io/ioutil has been deprecated. Go 1.22 was just released, and the go.mod specifies 'go 1.20'. This should be safe to remove at this point. The change was largely automated, minus the `t.TempDir()` calls inside test files, which was done manually.
Configuration menu - View commit details
-
Copy full SHA for 301d1b7 - Browse repository at this point
Copy the full SHA 301d1b7View commit details
Commits on Apr 11, 2024
-
testscript: add doc link to gotooltest
Otherwise it's not obvious that the "go" commands aren't a built-in feature.
Configuration menu - View commit details
-
Copy full SHA for 9d241da - Browse repository at this point
Copy the full SHA 9d241daView commit details -
testscript: Add Chdir method to change directory
It is not currently possible for a custom testscript command to change the working directory of that script run. `TestScript.Exec` runs the command in a subprocess, so one cannot do `ts.Exec("cd", dir)`. This change adds a `Chdir` method to `TestScript` that allows changing the working directory of the script. The implementation is the same as the "cd" command, which now relies on `Chdir`. The availability of this function matches similar functionality in the [`State.Chdir` method of rsc.io/script][1]. (I ported some tests from rsc.io/script to testscript.) [1]: https://pkg.go.dev/rsc.io/script#State.Chdir
Configuration menu - View commit details
-
Copy full SHA for 31b9365 - Browse repository at this point
Copy the full SHA 31b9365View commit details
Commits on Apr 15, 2024
-
testscript: add kill command (#243)
This allows sending a termination signal to backgrounded commands. Fixes #242.
Configuration menu - View commit details
-
Copy full SHA for 2af95f2 - Browse repository at this point
Copy the full SHA 2af95f2View commit details
Commits on May 9, 2024
-
testscript: clarify HOME and TMPDIR env var names
They aren't always HOME and TMPDIR; on GOOS=windows they are different.
Configuration menu - View commit details
-
Copy full SHA for c8567cf - Browse repository at this point
Copy the full SHA c8567cfView commit details
Commits on Jun 10, 2024
-
all: Add Go 1.22, drop Go 1.20
Switches CI to run against Go 1.21 and 1.22, and bumps the minimum required Go version to 1.21. Dropping 1.20 isn't strictly necessary; this is just matching prior upgrades. It can be added back if the maintainers prefer.
Configuration menu - View commit details
-
Copy full SHA for 1f3d244 - Browse repository at this point
Copy the full SHA 1f3d244View commit details -
update dependencies and rely on Go 1.21 APIs (#256)
We had been using ancient versions of golang.org/x modules, which passed the tests but wasn't great as they contain bugs and most users would want their newer versions anyway. Assume Go 1.21 later; use slices.Compact and simplify a test. While here, update the setup-go action as well.
Configuration menu - View commit details
-
Copy full SHA for ee2fcaa - Browse repository at this point
Copy the full SHA ee2fcaaView commit details -
cmd/testscript: remove redundant use of Failed (#257)
The call to `T.Failed` and its associated comment are a legacy of previous implementation. The comment isn't accurate and the call isn't necessary (`FailNow` is always called even when `ContinueOnError` is set). Deprecate the associated `TFailed` type rather than removing it.
Configuration menu - View commit details
-
Copy full SHA for 8300480 - Browse repository at this point
Copy the full SHA 8300480View commit details
Commits on Jun 11, 2024
-
testscript: add Config.Files (#258)
This makes it possible to pass an arbitrary set of testscript files to be run instead of just a directory, making it possible for the testscript command to pass its command line arguments directly. In order to check that all the files are actually tested, we need to make the test harness implement independent subtest failure, and it's useful to see the name of the test too so that we can see the name disambiguation logic at work, which makes for changes to some of the other tests too. Note that the name deduping logic is somewhat improved from similar logic in cmd/testscript, in that it is always guaranteed to produce unique names even in the presence of filenames that look like deduped names.
Configuration menu - View commit details
-
Copy full SHA for b143f3f - Browse repository at this point
Copy the full SHA b143f3fView commit details -
cmd/testscript: do not create an extra temporary directory (#259)
It's bugged me for a long time that the error messages printed by the `testscript` command do not refer to the actual files passed to the command, but instead to a temporary file created for the purposes of the command. This change alters the testscript command so that it avoids creating an extra copy of the script file, instead using the new ability of the testscript package to interpret explicitly provided files instead. Gratifyingly, this also simplifies the logic quite a bit. Note: this is dependent on #258, so should not be reviewed until that lands.
Configuration menu - View commit details
-
Copy full SHA for 5556500 - Browse repository at this point
Copy the full SHA 5556500View commit details
Commits on Jul 9, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 66960b6 - Browse repository at this point
Copy the full SHA 66960b6View commit details -
testscript: ignore result when interrupting background processes
When an entire script runs and the end is reached, any background processes begun with a '&' command get interrupted or killed, depending on the platform and timeout, and we wait for them to finish. We also checked their resulting status code and failed if they didn't exit with a status code of 0. However, as explained in the comment, this would always fail on Windows, given that it doesn't have interrupt signals so we would kill directly, causing a "signal: killed" error. Worse, any failures here caused a `panic: fail now!` as that is how we bubble up errors when a script command is being run, but such panics were not being recovered once we reached the end of a script. Now that we don't check the result anymore here, the panics are gone. Fixes #228. Fixes #260.
Configuration menu - View commit details
-
Copy full SHA for ccf4b43 - Browse repository at this point
Copy the full SHA ccf4b43View commit details
Commits on Sep 20, 2024
-
goproxytest: add test wrapper API
I found that cmd/cue's tests were chatty because goproxytest was complaining about missing modules which did not matter. Because those logs always went directly to os.Stderr, I couldn't fix it without changing the API in this package. Rather than adding a complex API that takes a logger, since nearly all downstream use cases come from Go tests, add an API on top of testing.TB which makes its use much nicer.
Configuration menu - View commit details
-
Copy full SHA for 361e7d2 - Browse repository at this point
Copy the full SHA 361e7d2View commit details -
dirhash: forward to golang.org/x/mod/sumdb/dirhash
It seems like x/mod/sumdb/dirhash appeared way back in 2019, and we had not noticed until now.
Configuration menu - View commit details
-
Copy full SHA for 3a65db1 - Browse repository at this point
Copy the full SHA 3a65db1View commit details
Commits on Sep 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 5ce929e - Browse repository at this point
Copy the full SHA 5ce929eView commit details -
cmp.Or and no longer needing to shallow copy range loop vars. While here, remove an unused parameter as spotted by gopls.
Configuration menu - View commit details
-
Copy full SHA for 4794549 - Browse repository at this point
Copy the full SHA 4794549View commit details -
README: update the package list
dirhash, modfile, module, and semver simply forward to the upstream packages now, so we should no longer advertise them to users. txtar is very close to that state, but not quite. Add a note.
Configuration menu - View commit details
-
Copy full SHA for e67a4aa - Browse repository at this point
Copy the full SHA e67a4aaView commit details
This comparison is taking too long to generate.
Unfortunately it looks like we can’t render this comparison for you right now. It might be too big, or there might be something weird with your repository.
You can try running this command locally to see the comparison on your machine:
git diff v1.12.0...v1.13.1