Skip to content

Conversation

andestaerfan
Copy link
Contributor

@andestaerfan andestaerfan commented Aug 6, 2022

Resolves #14

@andestaerfan andestaerfan mentioned this pull request Aug 6, 2022
Copy link
Owner

@rogerluan rogerluan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for opening this PR @erfanandesta1373 !
Do you mind adding ruby 2.6.9 (specifically), and perhaps also ruby 2.6 (which default to the latest patch version, which right now it's 2.6.10) to the list of ruby versions in .github/workflows/pull-request.yml and .github/workflows/push.yml? 🙏 this way we're sure everything runs smoothly in those versions as well (from a CI perspective).

Thanks!

@rogerluan rogerluan changed the title Add support for Bitrise latest Xcode Decrease Ruby version requirement to 2.6.x, supporting Bitrise default Ruby version out of the box Aug 6, 2022
Copy link
Owner

@rogerluan rogerluan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erfanandesta1373 I took the liberty of addressing the changes I had requested earlier, and also fixed a couple other issues that popped up, issues of which I had mentioned we'd probably have when decreasing the min ruby version to 2.6.x 😄

I think this PR is good to go now, I hope you don't mind I pushed some commits to your fork.

Thanks for the initiative of opening this PR! I'm merging this in, and will release it asap 😉

@rogerluan rogerluan merged commit f9310fe into rogerluan:main Aug 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Required Ruby version
2 participants