Skip to content

Conversation

Tinuvile
Copy link
Contributor

@Tinuvile Tinuvile commented Jul 8, 2025

What's changed and what's your intention?

  • Update the build-release.sh script to ensure the version file is created correctly during the build process
  • Change the version file path from ./version.ini to ./config/version.ini, and improve the information printed at startup
  • Optimize version information management, implement a three-layer fallback mechanism (runtime file, compile-time embedded version, Cargo.toml version), and add unit tests

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.
  • This PR does not require documentation updates.

Refer to a related PR or issue link

close #1253

@socutes
Copy link
Collaborator

socutes commented Jul 12, 2025

@Tinuvile Please fix the code style and resolve code conflicts

@Tinuvile Tinuvile force-pushed the feature/issue-1253-version-cache branch from b9f7035 to 3d72286 Compare July 13, 2025 16:20
Copy link
Collaborator

@socutes socutes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@socutes socutes merged commit e188784 into robustmq:main Jul 14, 2025
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Refactor] Version inforation management optimization
2 participants