Add samples for throwable expectations #990
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #990 +/- ##
=======================================
Coverage 90.86% 90.86%
=======================================
Files 433 433
Lines 4359 4359
Branches 219 219
=======================================
Hits 3961 3961
Misses 349 349
Partials 49 49
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
3 tasks
robstoll
requested changes
Oct 5, 2021
...on/src/test/kotlin/ch/tutteli/atrium/api/fluent/en_GB/samples/ThrowableExpectationSamples.kt
Outdated
Show resolved
Hide resolved
...on/src/test/kotlin/ch/tutteli/atrium/api/fluent/en_GB/samples/ThrowableExpectationSamples.kt
Outdated
Show resolved
Hide resolved
...on/src/test/kotlin/ch/tutteli/atrium/api/fluent/en_GB/samples/ThrowableExpectationSamples.kt
Outdated
Show resolved
Hide resolved
robstoll
reviewed
Oct 5, 2021
...on/src/test/kotlin/ch/tutteli/atrium/api/fluent/en_GB/samples/ThrowableExpectationSamples.kt
Outdated
Show resolved
Hide resolved
...on/src/test/kotlin/ch/tutteli/atrium/api/fluent/en_GB/samples/ThrowableExpectationSamples.kt
Outdated
Show resolved
Hide resolved
...on/src/test/kotlin/ch/tutteli/atrium/api/fluent/en_GB/samples/ThrowableExpectationSamples.kt
Outdated
Show resolved
Hide resolved
…in/ch/tutteli/atrium/api/fluent/en_GB/samples/ThrowableExpectationSamples.kt
…in/ch/tutteli/atrium/api/fluent/en_GB/samples/ThrowableExpectationSamples.kt
…in/ch/tutteli/atrium/api/fluent/en_GB/samples/ThrowableExpectationSamples.kt
robstoll
reviewed
Oct 5, 2021
...on/src/test/kotlin/ch/tutteli/atrium/api/fluent/en_GB/samples/ThrowableExpectationSamples.kt
Outdated
Show resolved
Hide resolved
...on/src/test/kotlin/ch/tutteli/atrium/api/fluent/en_GB/samples/ThrowableExpectationSamples.kt
Outdated
Show resolved
Hide resolved
…in/ch/tutteli/atrium/api/fluent/en_GB/samples/ThrowableExpectationSamples.kt
…in/ch/tutteli/atrium/api/fluent/en_GB/samples/ThrowableExpectationSamples.kt
robstoll
approved these changes
Oct 5, 2021
|
@szatyinadam thanks for you contribution 👍 would you mind adding the sample also to api-infix? See ch.tutteli.atrium.api.infix.en_GB.samples.AnyExpectationSamples for how the comments are written (e.g. toBeAnInstanceOfFeature and toBeAnInstanceOf) |
|
@robstoll Sure, I'm going to start it tonight. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add samples for
ThrowableExpectationsandThrowableAssertions.Related issue: #658