Migrate DescriptiveWithBasedOnSubjectSpec from spek to kotest #1235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jakubriegel
commented
Oct 27, 2022
| @@ -24,6 +24,7 @@ kotlin { | |||
| apiWithExclude("io.kotest:kotest-runner-junit5:$kotestVersion") | |||
| // necessary in order that intellij sees the io.kotest symbols (runner-junit5 actually already depends on it) | |||
| apiWithExclude("io.kotest:kotest-framework-api:$kotestVersion") | |||
| implementation("org.jetbrains.kotlinx:kotlinx-coroutines-core-jvm:1.3.9") | |||
There was a problem hiding this comment.
I'm not sure if this should be done this way in Atrium's dependencies setup. Feel free to suggest better approach.
Without adding coroutines explicitly as implementation here, gradle is not able to compile the code.
There was a problem hiding this comment.
All fine, I can still improve after merge
|
@robstoll If review will take more time, is it possible, that we add |
robstoll
approved these changes
Oct 31, 2022
|
@jakubriegel looks good to me, thanks for the contribution |
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refers to #1194
I confirm that I have read the Contributor Agreements v1.0, agree to be bound on them and confirm that my contribution is compliant.