648 add samples for feature assertions of api fluent #1037
Conversation
Codecov Report
@@ Coverage Diff @@
## main #1037 +/- ##
==========================================
Coverage 90.53% 90.53%
==========================================
Files 441 441
Lines 4629 4629
Branches 221 221
==========================================
Hits 4191 4191
Misses 389 389
Partials 49 49
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
|
Hey @robstoll, can I bug you for a review? |
There was a problem hiding this comment.
@iljakorneckis I am sorry, it looks like I forgot to press the submit button (I actually reviewed the same day you submitted 🤦♂️ )
...common/src/test/kotlin/ch/tutteli/atrium/api/fluent/en_GB/samples/FeatureExtractorSamples.kt
Outdated
Show resolved
Hide resolved
|
|
||
| fails { | ||
| expect(person) | ||
| .feature(Person::name) |
There was a problem hiding this comment.
always mention when the subject changes its type please
...common/src/test/kotlin/ch/tutteli/atrium/api/fluent/en_GB/samples/FeatureExtractorSamples.kt
Outdated
Show resolved
Hide resolved
...common/src/test/kotlin/ch/tutteli/atrium/api/fluent/en_GB/samples/FeatureExtractorSamples.kt
Outdated
Show resolved
Hide resolved
| // https://github.com/robstoll/atrium#define-single-expectations-or-expectation-groups | ||
|
|
||
| toStartWith("Kevin") // fails | ||
| toEndWith("Bacon") // still evaluated, use `.feature.` if you want fail fast behaviour |
There was a problem hiding this comment.
| toEndWith("Bacon") // still evaluated, use `.feature.` if you want fail fast behaviour | |
| toEndWith("Bacon") // still evaluated, use `.feature.` if you want fail fast behaviour |
...common/src/test/kotlin/ch/tutteli/atrium/api/fluent/en_GB/samples/FeatureExtractorSamples.kt
Outdated
Show resolved
Hide resolved
|
All good, @robstoll I'll make the changes asap and re-submit |
…in/ch/tutteli/atrium/api/fluent/en_GB/samples/FeatureExtractorSamples.kt
…in/ch/tutteli/atrium/api/fluent/en_GB/samples/FeatureExtractorSamples.kt
…in/ch/tutteli/atrium/api/fluent/en_GB/samples/FeatureExtractorSamples.kt
|
@iljakorneckis thanks for the changes and the contribution as such 🎉 |
|
Uh, @robstoll, I haven't done all the changes requested in the review. Sorry if I was unclear, when I resolved one of them. Should I open a separate PR for the rest? |
|
@iljakorneckis ah sorry, I figured you don't have time for the rest. I adjusted the last bits myself. |
|
@iljakorneckis If you should have more time available, then don't hesitate to take a look at other issues 🙂 |
|
@robstoll Hah, thank you for tackling the rest! I will definitely look at other issues that I can take. Learned a lot about multi-platform Kotlin from this project and started using it myself. 👍 |
|
@iljakorneckis just be aware of that this project actually uses the old multi-platform plugins (we need to update to the new soonish). If you are interested about the new plugins then take a look at the following issue: #744 |
Closes #648
I'm a little unsure about naming of the sample methods, so welcome any feedback and will make all required changes asap.
I confirm that I have read the Contributor Agreements v1.0, agree to be bound on them and confirm that my contribution is compliant.