use IR-backend for JS #1668
Merged
use IR-backend for JS #1668
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- need to add compileOnly to modules using logic as it looks like IR behaves differently and doesn't "inherit" the compile only dependencies - update to kbox 1.0.0 which also uses IR for JS - cannot longer use the mock of spek for js as it is compiled for LEGACY add own mocks - same same for mockk
84be7d4 to
46566a1
Compare
This was
linked to
issues
Jan 20, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1668 +/- ##
=========================================
Coverage 91.83% 91.83%
Complexity 114 114
=========================================
Files 423 423
Lines 4604 4604
Branches 228 228
=========================================
Hits 4228 4228
Misses 330 330
Partials 46 46
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
46566a1 to
a90c50d
Compare
which basically means we will no longer be able to use $metadata$.interfaces on an instance as it no longer exists. Interfaces are now numbers, and I did not have the time to find out where the number to name mapping is. moreover: - KotlinTestTeamCityConsoleAdapter cuts off the column number from stacktraces (see https://youtrack.jetbrains.com/issue/KT-64188), making it impossible to jump in the console to the correct place (jumps only to file) implement a workaround which appends a third number so that we keep the column number after KotlinTestTeamCityConsoleAdapter has cut off the third number - remove new clutter from stacktrace (.protoOf. and name mangling). - adapt KClassFullNameTest as some simpleName bugs have been fixed (and some new were introduced)
a90c50d to
bb3f02a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I confirm that I have read the Contributor Agreements v1.0, agree to be bound on them and confirm that my contribution is compliant.