feat(1654): add ListFeatureExtractor.last #1664
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a "last" function and simple tests for it.
12 tasks
|
@constantine-zubrilin shall I already take a look or do you let me know once it is ready for review |
|
Too early yet, I'll let you know, thank you
…On Wed, 10 Jan 2024, 22:32 Robert Stoll, ***@***.***> wrote:
@constantine-zubrilin <https://github.com/constantine-zubrilin> shall I
already take a look or do you let me know once it is ready for review
—
Reply to this email directly, view it on GitHub
<#1664 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABJPRBI7YVA2ZAQHARPTJ2TYN3UGTAVCNFSM6AAAAABBTXZ4A6VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQOBVGU3TONZQGE>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
Add a "last" function to infix api
Improve tests
Create listExpectations
Add comments.
...rium-api-fluent/src/commonMain/kotlin/ch/tutteli/atrium/api/fluent/en_GB/listExpectations.kt
Outdated
Show resolved
Hide resolved
|
@robstoll, can you please have a look? |
robstoll
reviewed
Jan 20, 2024
...rium-api-fluent/src/commonMain/kotlin/ch/tutteli/atrium/api/fluent/en_GB/listExpectations.kt
Outdated
Show resolved
Hide resolved
...rium-api-fluent/src/commonMain/kotlin/ch/tutteli/atrium/api/fluent/en_GB/listExpectations.kt
Outdated
Show resolved
Hide resolved
...rium-api-fluent/src/commonMain/kotlin/ch/tutteli/atrium/api/fluent/en_GB/listExpectations.kt
Outdated
Show resolved
Hide resolved
...api-fluent/src/commonMain/kotlin/ch/tutteli/atrium/api/fluent/en_GB/listFeatureExtractors.kt
Outdated
Show resolved
Hide resolved
.../commonTest/kotlin/ch/tutteli/atrium/api/fluent/en_GB/samples/ListFeatureExtractorSamples.kt
Outdated
Show resolved
Hide resolved
...atrium-api-infix/src/commonMain/kotlin/ch/tutteli/atrium/api/infix/en_GB/listExpectations.kt
Outdated
Show resolved
Hide resolved
...atrium-api-infix/src/commonMain/kotlin/ch/tutteli/atrium/api/infix/en_GB/listExpectations.kt
Outdated
Show resolved
Hide resolved
...m-api-infix/src/commonMain/kotlin/ch/tutteli/atrium/api/infix/en_GB/listFeatureExtractors.kt
Outdated
Show resolved
Hide resolved
...en_GB/src/commonMain/kotlin/ch/tutteli/atrium/translations/DescriptionListLikeExpectation.kt
Outdated
Show resolved
Hide resolved
...rium-specs/src/commonMain/kotlin/ch/tutteli/atrium/specs/integration/ListExpectationsSpec.kt
Outdated
Show resolved
Hide resolved
…/atrium/api/fluent/en_GB/listExpectations.kt Co-authored-by: Robert Stoll <rstoll@tutteli.ch>
…/atrium/api/fluent/en_GB/listExpectations.kt Co-authored-by: Robert Stoll <rstoll@tutteli.ch>
…trium/api/infix/en_GB/listExpectations.kt Co-authored-by: Robert Stoll <rstoll@tutteli.ch>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1664 +/- ##
============================================
+ Coverage 91.83% 91.85% +0.02%
Complexity 114 114
============================================
Files 423 423
Lines 4604 4617 +13
Branches 228 229 +1
============================================
+ Hits 4228 4241 +13
Misses 330 330
Partials 46 46
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
…/atrium/api/fluent/en_GB/listFeatureExtractors.kt Co-authored-by: Robert Stoll <rstoll@tutteli.ch>
…trium/api/infix/en_GB/listExpectations.kt Co-authored-by: Robert Stoll <rstoll@tutteli.ch>
…trium/api/infix/en_GB/listFeatureExtractors.kt Co-authored-by: Robert Stoll <rstoll@tutteli.ch>
Code review fixes
robstoll
reviewed
Jan 24, 2024
...api-fluent/src/commonMain/kotlin/ch/tutteli/atrium/api/fluent/en_GB/listFeatureExtractors.kt
Show resolved
Hide resolved
robstoll
requested changes
Jan 24, 2024
.../commonTest/kotlin/ch/tutteli/atrium/api/fluent/en_GB/samples/ListFeatureExtractorSamples.kt
Outdated
Show resolved
Hide resolved
...c/commonTest/kotlin/ch/tutteli/atrium/api/infix/en_GB/samples/ListFeatureExtractorSamples.kt
Outdated
Show resolved
Hide resolved
...de_CH/src/commonMain/kotlin/ch/tutteli/atrium/translations/DescriptionListLikeExpectation.kt
Outdated
Show resolved
Hide resolved
...en_GB/src/commonMain/kotlin/ch/tutteli/atrium/translations/DescriptionListLikeExpectation.kt
Outdated
Show resolved
Hide resolved
…h/tutteli/atrium/translations/DescriptionListLikeExpectation.kt Co-authored-by: Robert Stoll <rstoll@tutteli.ch>
…h/tutteli/atrium/translations/DescriptionListLikeExpectation.kt Co-authored-by: Robert Stoll <rstoll@tutteli.ch>
…/atrium/api/fluent/en_GB/samples/ListFeatureExtractorSamples.kt Co-authored-by: Robert Stoll <rstoll@tutteli.ch>
Code review fixes
robstoll
approved these changes
Jan 25, 2024
|
@constantine-zubrilin thanks for your first contribution to Atrium 🙂👍 |
12 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a "last" function and simple tests for it.
I confirm that I have read the Contributor Agreements v1.0, agree to be bound on them and confirm that my contribution is compliant.