-
-
Notifications
You must be signed in to change notification settings - Fork 226
Closed
Description
Platform (all, jvm, js): jvm
Extension (none, kotlin 1.3): none
Code related feature
expect(Date()).asLocalDate().toBeAfter(...)
//instead of
expect(Date().toInstant().atZone(ZoneId.systemDefault()).toLocalDate()).toBeAfter(...);
Following the things you need to do:
api-fluent
- provide a val which returns
Expect<LocalDate>
in dateSubjectChangers.kt (see fileSubjectChangers.kt as a guideline) - provide a fun which expects an
assertionCreator
-lambda and returnsExpect<Date>
in dateSubjectChangers.kt (see fileSubjectChangers.kt as a guideline) - add
@since 0.19.0
(adapt to current milestone) to KDOC - extend or write a separate Spec named DateAsLocalDateExpectationsSpec in specs -> jvmMain (see for instance FileAsPathExpectationsSpec) and extend it in atrium-api-fluent-en_GB -> jvmTest
api-infix
- provide a val which returns
Expect<Date>
in dateSubjectChangers.kt(see fileSubjectChangers.kt as a guideline) - provide a fun which expects an
assertionCreator
-lambda and returnsExpect<AB>
in dateSubjectChangers.kt (see fileSubjectChangers.kt as a guideline) - add
@since 0.19.0
(adapt to current milestone) to KDOC - extend or write a separate Spec named DateAsLocalDateExpectationsSpec in specs -> commonMain (see for instance FileAsPathExpectationsSpec) and extend it in atrium-api-infix-en_GB -> jvmTest
Your first contribution?
- Write a comment
I'll work on this
if you would like to take this issue over.
This way we get the chance to revise the description in case things have changed in the meantime, we might give you additional hints and we can assign the task to you, so that others do not start as well. - See Your first code contribution for guidelines.
- Do not hesitate to ask questions here or to contact us via Atrium's slack channel if you need help
(Invite yourself in case you do not have an account yet).