[nix] Add flake support to wander #115
Conversation
This commit lets flake users import wander package directly from the repo, as well as quickly run wander with nix run "github:robinovitch61/wander"
|
This is awesome! Thank you @dbalan :) Question: the version shown on wander is The version is pulled either from the git repo if it's being built in a context with the repo data, or manually specified with ldflags as per this bit of the README. My preference would be to have the version set and not have to be manually specified and kept in sync with the git tags. Think there's any way to do this reliably? |
Co-authored-by: Leo Robinovitch <leorobinovitch@gmail.com>
| src = ./.; | ||
|
|
There was a problem hiding this comment.
| src = ./.; | |
| src = ./.; | |
| ldflags = | |
| [ "-X github.com/robinovitch61/wander/cmd.Version=v0.14.0" ]; |
The way to plug in version would be to add it to the build spec like above. I don't think there is any way to plug this in dynamically.
By default, nix flake just grabs whatever commit main is on, and pins that version in flake.lock. If we have a workflow to keep bumping this on releases, the actual code would but the release tag and commits on top.
How do you feel about it? The other option is to set the version for flake to something static like, v{version}-flake or just flake.
There was a problem hiding this comment.
ping @robinovitch61 :)
There was a problem hiding this comment.
Ah sorry for the delay, for some reason wasn't getting emails about this! Gonna merge as is and see what I can do about the version embed later, thanks so much for this :)
This commit lets flake users import wander package directly from the repo, as well as quickly run wander with