Skip to content

fix: remote helmfile from git::ssh source #719

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 25, 2019
Merged

fix: remote helmfile from git::ssh source #719

merged 1 commit into from
Jun 25, 2019

Conversation

mumoshu
Copy link
Collaborator

@mumoshu mumoshu commented Jun 25, 2019

The remote helmfile feature introduced by #648 was unable to be sourced from private git repositories due to URL parsing issue in helmfile. This fixes that.

Ref #469 (comment)

@mumoshu
fix: remote helmfile from git::ssh source
ca9155f 
The remote helmfile feature introduced by #648 was unable to be sourced from private git repositories due to URL parsing issue in helmfile. This fixes that.

Ref #469 (comment)
@mumoshu mumoshu mentioned this pull request Jun 25, 2019
Open
@mumoshu mumoshu merged commit e6bb828 into master Jun 25, 2019
@mumoshu mumoshu deleted the fix-git-ssh-private-repo-source branch June 25, 2019 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@kamsz kamsz kamsz approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mumoshu @kamsz