Remove the latest android-all from the runtime classpath when running Robolectric tests #9358
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MGaetan89
reviewed
Jul 26, 2024
robolectric/build.gradle
Outdated
| testRuntimeOnly files("${System.getenv("ANDROID_HOME")}/platforms/android-34/android.jar") |
There was a problem hiding this comment.
Maybe we should define a variable in Gradle with the compile SDK version, so we can use it everywhere, and in particular her.
I have a feeling it will be rather easy to forget to update this value when compile SDK is changed (I suppose that's why 34 is used?).
There was a problem hiding this comment.
Yeah definitely a good idea, this PR is still a WIP, just trying to see if this will cause any issues.
f8bb8d0 to
5ad563e
Compare
|
@Mia0451 I think this PR can solve your problems. |
utzcoz
reviewed
Jul 28, 2024
e2011ee to
4765657
Compare
utzcoz
approved these changes
Jul 30, 2024
MGaetan89
approved these changes
Jul 30, 2024
Previously, the android-all from U was on the runtime classpath when running Robolectric tests. This gave tests the ability to use any class from Android U, even on older SDK levels. Update the gradle logic to include the android 34 stubs jar on the classpath. If tests for an older SDK level inadvertently try to use classes from U, a Stub! exception will be thrown. Fixes robolectric#9357
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #9357