Skip to content

Disable shadowOf generation for FileIntegrityManager #9038

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 1, 2024
Merged

Disable shadowOf generation for FileIntegrityManager #9038

merged 1 commit into from
May 1, 2024

Conversation

hoisie
Copy link
Contributor

@hoisie hoisie commented May 1, 2024

FileIntegrityManager was added in Android R, and we are currently supporting shadowOf for compileSdk >= Q.

@hoisie
Disable shadowOf generation for FileIntegrityManager
8028dd0 
FileIntegrityManager was added in Android R, and we are currently
supporting shadowOf for compileSdk >= Q.
@hoisie hoisie merged commit c6b2e73 into robolectric:master May 1, 2024
@hoisie hoisie deleted the fix-build branch May 2, 2024 05:43
@utzcoz
Copy link
Member

utzcoz commented May 2, 2024

@hoisie Looks like this PR breaks the CI.

@hoisie
Copy link
Contributor Author

hoisie commented May 2, 2024

@utzcoz the CI was broken due to two issues.

One of the issues was fixed by this PR. If you revert this PR and run:

./gradlew :integration_tests:sdkcompat:test, it will fail with the error:

/usr/local/google/home/hoisie/workspace/robolectric/integration_tests/sdkcompat/src/test/java/org/robolectric/integrationtests/sdkcompat/JavaClassResolveCompatibilityTest.java:26: error: cannot access FileIntegrityManager
    assertThat(Shadows.shadowOf(RuntimeEnvironment.getApplication())).isNotNull();
                      ^
  class file for android.security.FileIntegrityManager not found
1 error

There is another RNG test that is broken on Mac only, I will ignore that for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hoisie @utzcoz