Skip to content

Fix sandboxed class lookup when a test is subclassed. #8003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 0 commits into from
Mar 6, 2023
Merged

Fix sandboxed class lookup when a test is subclassed. #8003

merged 0 commits into from
Mar 6, 2023

Conversation

copybara-service[bot]
Copy link

Fix sandboxed class lookup when a test is subclassed.

This can happen with the following structure:

class MyBase {
  @Test public void myTest() {}
}

@RunWith(RobolectricTestRunner.class)
class MyTest extends MyBase {
  @Override public void myTest() {}
}

In this case the method marked @Test is MyBase.myTest but the old behavior in SandboxTestRunner was to create a framework method in the sandbox for MyTest.myTest.

@copybara-service copybara-service bot closed this Mar 6, 2023
@copybara-service copybara-service bot deleted the piper_513686914 branch March 6, 2023 15:12
@copybara-service copybara-service bot merged commit ec8d734 into google Mar 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
0 participants