Convert test code of maven-dependency-resolver to Kotlin #7947
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jan 28, 2023
d2adff5 to
87e2114
Compare
|
Hi @hoisie @brettchabot , PTAL. |
Goooler
reviewed
Feb 15, 2023
87e2114 to
780cb71
Compare
Goooler
reviewed
Feb 19, 2023
Signed-off-by: utzcoz <utzcoz@outlook.com> Signed-off-by: sagarkhurana00786@gmail.com
780cb71 to
1ca195c
Compare
|
Hi @hoisie, what about this PR? |
|
I decide to merge it after long time no response. cc @hoisie. |
|
cc @hellosagar for your previouos work progress. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
getLocalRepositoryDirfrom customMavenDependencyResolverinstance in test file, because it is not easy to call super class' private filed, although we do it with reflection.