-
Notifications
You must be signed in to change notification settings - Fork 1.4k
Fix Javadoc for ShadowPausedLooper
#10387
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix Javadoc for ShadowPausedLooper
#10387
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request addresses a Javadoc formatting error in ShadowPausedLooper.java
by correcting the placement of an 'and' conjunction and ensuring proper linking of enum constants. The fix improves Javadoc clarity. My review includes one suggestion to further refine the line wrapping of a {@link}
tag to enhance robustness with Javadoc processing tools and align with common Javadoc formatting practices.
shadows/framework/src/main/java/org/robolectric/shadows/ShadowPausedLooper.java
Show resolved
Hide resolved
The Javadoc for `ShadowPausedLooper` had a formatting error that caused it to not render correctly.
d503b8e
to
5079919
Compare
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request effectively addresses Javadoc formatting issues in ShadowPausedLooper.java
.
The corrections to {@link}
tag syntax and the reformatting of a descriptive list into an HTML unordered list significantly improve the clarity and correctness of the documentation.
These changes adhere to standard Java Javadoc best practices, which emphasize correct syntax for Javadoc tags (e.g., {@link}
) and the use of appropriate HTML (e.g., <ul>
for lists) to ensure documentation is both machine-parsable and human-readable. The result is an enhancement to the overall quality of the codebase's documentation.
shadows/framework/src/main/java/org/robolectric/shadows/ShadowPausedLooper.java
Show resolved
Hide resolved
shadows/framework/src/main/java/org/robolectric/shadows/ShadowPausedLooper.java
Show resolved
Hide resolved
@MGaetan89 Could you give a screenshot for the new comment? |
Of course! Here's a comparison in the IDE:
And a comparison of the HTML Javadoc:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!!
The Javadoc for
ShadowPausedLooper
had a formatting error that caused it to not render correctly.This commit also fixes the item list in
ShadowPausedLooper
's Javadoc.