Skip to content

Conversation

MGaetan89
Copy link
Member

@MGaetan89 MGaetan89 commented Jun 11, 2025

The Javadoc for ShadowPausedLooper had a formatting error that caused it to not render correctly.
This commit also fixes the item list in ShadowPausedLooper's Javadoc.

@MGaetan89 MGaetan89 self-assigned this Jun 11, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request addresses a Javadoc formatting error in ShadowPausedLooper.java by correcting the placement of an 'and' conjunction and ensuring proper linking of enum constants. The fix improves Javadoc clarity. My review includes one suggestion to further refine the line wrapping of a {@link} tag to enhance robustness with Javadoc processing tools and align with common Javadoc formatting practices.

The Javadoc for `ShadowPausedLooper` had a formatting error that caused it to not render correctly.
@MGaetan89 MGaetan89 force-pushed the fix_ShadowPausedLooper_doc branch from d503b8e to 5079919 Compare June 11, 2025 11:32
@MGaetan89
Copy link
Member Author

/gemini review

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request effectively addresses Javadoc formatting issues in ShadowPausedLooper.java.
The corrections to {@link} tag syntax and the reformatting of a descriptive list into an HTML unordered list significantly improve the clarity and correctness of the documentation.
These changes adhere to standard Java Javadoc best practices, which emphasize correct syntax for Javadoc tags (e.g., {@link}) and the use of appropriate HTML (e.g., <ul> for lists) to ensure documentation is both machine-parsable and human-readable. The result is an enhancement to the overall quality of the codebase's documentation.

@utzcoz
Copy link
Member

utzcoz commented Jun 11, 2025

@MGaetan89 Could you give a screenshot for the new comment?

@MGaetan89
Copy link
Member Author

@MGaetan89 Could you give a screenshot for the new comment?

Of course!

Here's a comparison in the IDE:

Before After
Screenshot 2025-06-11 at 20 34 52 Screenshot 2025-06-11 at 20 35 16

And a comparison of the HTML Javadoc:

Before After
Screenshot 2025-06-11 at 20 38 28 Screenshot 2025-06-11 at 20 38 46

Copy link
Contributor

@hoisie hoisie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!!

@MGaetan89 MGaetan89 merged commit 408d333 into robolectric:master Jun 11, 2025
21 checks passed
@MGaetan89 MGaetan89 deleted the fix_ShadowPausedLooper_doc branch June 11, 2025 19:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants