Add ShadowTextureView to noOp drawing with it. #10433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TextureView uses OpenGL to do it's drawing, so even the native code will return 0 when trying to use nCreateTextureLayer. This causes a crash because the hardwareRenderer/deferredRenderer is 0 so the initialization crashes. This change makes the getTextureLayer function of TextureView do nothing so it will at least continue the test and draw everything else even if this isn't able to. PiperOrigin-RevId: 776611916
f8eb87b to
d5f1755
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add ShadowTextureView to noOp drawing with it.
TextureView uses OpenGL to do it's drawing, so even the native
code will return 0 when trying to use nCreateTextureLayer. This
causes a crash because the hardwareRenderer/deferredRenderer is
0 so the initialization crashes.
This change makes the getTextureLayer function of TextureView do nothing so
it will at least continue the test and draw everything else even
if this isn't able to.