Remove deckard references from the readme
#10431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Both deckard repositories (for Gradle and Maven) haven't been updated in years, and have been archived last February. This commit removes the references to these projects, as they don't really help getting started with Robolectric.
| @Test | ||
| public void clickingButton_shouldChangeMessage() { | ||
| try (ActivityController<MyActivity> controller = Robolectric.buildActivity(MyActivity.class)) { | ||
| controller.setup(); // Moves Activity to RESUMED state | ||
| controller.setup(); // Moves the Activity to the RESUMED state |
There was a problem hiding this comment.
Consider using a more descriptive comment to explain what the setup() method does. While it moves the Activity to the RESUMED state, elaborating on the implications or purpose of this state change could be beneficial for readers unfamiliar with the Activity lifecycle.
Suggested change
| controller.setup(); // Moves the Activity to the RESUMED state | |
| controller.setup(); // Moves the Activity to the RESUMED state, making it ready for user interaction |
There was a problem hiding this comment.
Not sure if it is relevant to include this. Let me know if you think it makes sense
There was a problem hiding this comment.
It's fine to keep the existing version instead of Gemini one.
utzcoz
approved these changes
Jul 8, 2025
|
Thanks for deleting this. The deckard project is highly obsolete. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both deckard repositories (for Gradle and Maven) haven't been updated in years, and have been archived last February.
This commit removes the references to these projects, as they don't really help getting started with Robolectric.
Here's the updated section of the readme:
