Remove testDebugUnitTest from the dependencies of the simulator task
#10413
Conversation
There was a problem hiding this comment.
Code Review
This pull request successfully removes the dependency on the testDebugUnitTest task from the simulator task, ensuring that only the assembleDebug task is executed to provide the necessary APK for the simulator. This change aligns with the stated objective and improves the efficiency of the simulation task.
| @@ -87,7 +86,7 @@ class SimulatorPlugin : Plugin<Project> { | |||
| jvmArgs = testTask.jvmArgs + robolectricJvmArgs | |||
| mainClass.set(MAIN_CLASS) | |||
| args = listOf(resourceApkFile.absolutePath) | |||
| dependsOn(testTaskName, "assembleDebug") | |||
| dependsOn("assembleDebug") | |||
There was a problem hiding this comment.
Removing the dependency on testDebugUnitTest from the dependsOn list for the simulate task aligns with the PR description and correctly ensures that the test task is not executed unnecessarily when only the simulator is needed. This improves the efficiency of the simulate task.
| @@ -87,7 +86,7 @@ class SimulatorPlugin : Plugin<Project> { | |||
| jvmArgs = testTask.jvmArgs + robolectricJvmArgs | |||
| mainClass.set(MAIN_CLASS) | |||
| args = listOf(resourceApkFile.absolutePath) | |||
| dependsOn(testTaskName, "assembleDebug") | |||
| dependsOn("assembleDebug") | |||
There was a problem hiding this comment.
IIUC, this simulate task requires debutTest task finished?
There was a problem hiding this comment.
What I know is that "apk" in test environment is liek "xxx._ap", and it is generated by test task. If you we remove this task dependency, how can we ensure the "apk" file is generated ?
There was a problem hiding this comment.
Ah, I thought it was looking for the app APK, not the test APK.
So maybe, dependsOn should include the following. What do you think?
dependsOn(targetTask, "assembleDebug"
There was a problem hiding this comment.
I tried to run the packageDebugUnitTestForUnitTest locally, but it was not found (using AGP 8.10.1). Maybe we need to find a better way to generate the apk-for-local-test.ap_ file (as suggested in #10382, suggestion 7)?
There was a problem hiding this comment.
My bad, the issue was that I didn't set unitTests.isIncludeAndroidResources = true.
I'll add a tip here if the task is not found.
There was a problem hiding this comment.
FWIW I just upgraded to AGP 8.10.1 and the task packageDebugUnitTestForUnitTest exists for me in a very simple project.
There was a problem hiding this comment.
@MGaetan89 that sounds great, thanks. We should also consider failing Robolectric tests if the ap_ is not supplied as well, but that can be a separate thing.
There was a problem hiding this comment.
@hoisie I've pushed the changes. Can you try again?
The build is already failed when the .ap_ is not find:
Or do you have something else in mind?
There was a problem hiding this comment.
Yeah I was thinking that RobolectricTestRunner could check for the ap_ file to be supplied, to force people to set unitTests.isIncludeAndroidResources = true for tests as well (not just the simulator). But that can be a separate issue.
70261d0 to
1a64763
Compare
This commit removes the dependency on the test task when running the `simulator` task. We only need the `assembleDebug` task, to have an APK to run in the simulator. Fixes robolectric#10412
|
Thank you @MGaetan89 for quickly resolving this issue, I'll CP these fixes and push out 4.15. |
This commit removes the dependency on the test task when running the
simulatortask.We only need the
assembleDebugtask, to have an APK to run in the simulator.Fixes #10412