Skip to content

Remove warnings from configuration and compilation #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Dec 6, 2024
Merged

Remove warnings from configuration and compilation #249

merged 3 commits into from
Dec 6, 2024

Conversation

traversaro
Copy link
Member

@traversaro traversaro commented Dec 6, 2024 •
edited
Loading

The headers were deprecated in iDynTree 10.0.0 released in November 2023: https://github.com/robotology/idyntree/releases/tag/v10.0.0 .

Furthermore, we also switch from linking to idyntree-modelio-urdf to idyntree-modelio, to avoid the warning:

2024-12-06T13:09:27.6936842Z CMake Warning (dev) at toolbox/base/CMakeLists.txt:21 (target_link_libraries):
2024-12-06T13:09:27.6937560Z   The library that is being linked to, iDynTree::idyntree-modelio-urdf, is
2024-12-06T13:09:27.6938249Z   marked as being deprecated by the owner.  The message provided by the
2024-12-06T13:09:27.6938775Z   developer is:
2024-12-06T13:09:27.6939077Z 
2024-12-06T13:09:27.6939332Z   Do not use deprecated target iDynTree::idyntree-modelio-urdf, use
2024-12-06T13:09:27.6939859Z   iDynTree::idyntree-modelio instead.

I also bumped the minimum CMake version to 3.16 to avoid the warning:

CMake Deprecation Warning at CMakeLists.txt:5 (cmake_minimum_required):
  Compatibility with CMake < 3.10 will be removed from a future version of
  CMake.

  Update the VERSION argument <min> value.  Or, use the <min>...<max> syntax
  to tell CMake that the project requires at least <min> but has been updated
  to work with policies introduced by <max> or earlier.

@traversaro traversaro requested a review from Gio-DS December 6, 2024 13:23
@traversaro traversaro changed the title Use modern iDynTree header inclusions to avoid deprecation warnings Remove warnings from configuration and compilation Dec 6, 2024
@traversaro traversaro merged commit 6f52ead into master Dec 6, 2024
7 of 9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gio-DS Gio-DS Awaiting requested review from Gio-DS

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@traversaro