Skip to content

Conversation

jychen7
Copy link
Collaborator

@jychen7 jychen7 commented Jan 22, 2023

What

final part of #240

close #121

Test

Integration test is added in CI.

I do NOT test with real Azure Storage, as don't have account.
(ps: And free trial require phone number and credit card, not favour providing those to Microsoft, 😂 )

Document

roapi/docs#17

To Reviewer

After this PR, we can finally release 0.9.0 😄

Copy link
Member

@houqp houqp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Left 1 minor comment

@jychen7 jychen7 requested a review from houqp January 22, 2023 22:51
@houqp houqp merged commit 2ec39dd into roapi:main Jan 24, 2023
@houqp
Copy link
Member

houqp commented Jan 24, 2023

Let's bump the version and aim for a new release this weekend?

@jychen7 jychen7 deleted the 240-azure branch January 24, 2023 02:29
@jychen7
Copy link
Collaborator Author

jychen7 commented Jan 24, 2023

Let's bump the version and aim for a new release this weekend?

sounds good, PR: #251

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for azure blob storage
2 participants